Re: [PATCH v3 15/20] ARM: LPAE: use phys_addr_t instead of unsigned long for physical addresses

From: Arnd Bergmann
Date: Wed Nov 17 2010 - 10:41:00 EST


On Wednesday 17 November 2010, Catalin Marinas wrote:
> That's what I plan to add, though it may be better to push as a
> separate patch to fix compiler warnings now. I don't know when the
> LPAE patches would go in.
>
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -189,7 +189,7 @@
> * translation for translating DMA addresses. Use the driver
> * DMA support - see dma-mapping.h.
> */
> -static inline phys_addr_t virt_to_phys(void *x)
> +static inline phys_addr_t virt_to_phys(const volatile void *x)
> {
> return __virt_to_phys((unsigned long)(x));
> }

The only impact of this patch is reducing compiler warnings, it should
not add any. Since the patch is correct and independent of the other
changes, it still sounds like a good idea to push it into -next now.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/