Re: [PATCH] regulator: Move lp3971 regulator driver tosubsys_initcall()

From: Mark Brown
Date: Wed Nov 17 2010 - 08:32:23 EST


On Wed, Nov 17, 2010 at 09:12:05AM +0100, Wolfram Sang wrote:
> On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:

> > Regulators need to be available early in init in order to allow them
> > to be available for consumers when requested.

> > Other regulator drivers are already moved to subsys_initcall(),
> > looks like only lp3971 is missing.

> My 2 cents: it is safer to create such patches with real HW when there is a
> need (we deal with a similar situation in i2c). Janitorial might do more harm
> than good. Another option might be to call the patch a RFC?

Essentially any regulator driver has this requirement, it's just
something that was missed in the review when the patch was merged.
Grant has an idea for dealing with this differently by postpoing
registraton of dependant devices but for now all regulator drivers
should be registered early.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/