Re: [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF enabling

[Yinghai Lu]

On Tue, Nov 16, 2010 at 11:52 PM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>>>> On 16.11.10 at 23:26, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On 11/16/2010 12:25 AM, Jan Beulich wrote:
>>> @@ -206,8 +200,10 @@ void __cpuinit fam10h_check_enable_mmcfg
>>>       * with 256 buses
>>>       */
>>>      get_fam10h_pci_mmconf_base();
>>> -    if (fam10h_pci_mmconf_base_status <= 0)
>>> +    if (!fam10h_pci_mmconf_base) {
>>> +            pci_probe &= ~PCI_CHECK_ENABLE_AMD_MMCONF;
>>
>> case: if no cpu mmconf reg are set by BIOS and later if BSP can not get new
>> base,
>>
>> this pci_probe &= line will be called for every AP...
>
> No, because the function itself has
>
>        if (!(pci_probe & PCI_CHECK_ENABLE_AMD_MMCONF))
>                return;
>
> at its very beginning.

ok.

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/