Re: [RFC][PATCH 1/5] [PATCH 1/5] events: Add EVENT_FS the eventfilesystem

From: Greg KH
Date: Tue Nov 16 2010 - 22:32:33 EST


On Tue, Nov 16, 2010 at 07:53:58PM -0500, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@xxxxxxxxxx>
>
> Copied mostly from debugfs, the eventfs is the filesystem
> that will include stable tracepoints. Currently nothing
> enables this filesystem as of this patch.

What? Wait, I wrote tracefs a long time ago just for this, why not take
that code and use it instead?

{sigh} And I just deleted that old tracefs git tree today as I thought
that idea was long gone and dead....

>
> Cc: Greg KH <gregkh@xxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ---
> fs/Kconfig | 6 +
> fs/Makefile | 1 +
> fs/eventfs/Makefile | 4 +
> fs/eventfs/file.c | 53 ++++++
> fs/eventfs/inode.c | 433 +++++++++++++++++++++++++++++++++++++++++++++++

This seems a bit big, I don't think you need all of this for some
reason. Are you sure you can't make it smaller?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/