Re: rfc: rewrite commit subject line for subsystem maintainerpreference tool

From: Randy Dunlap
Date: Tue Nov 16 2010 - 15:21:14 EST


On Tue, 16 Nov 2010 19:55:31 +0000 Mark Brown wrote:

> On Tue, Nov 16, 2010 at 08:35:22PM +0100, Florian Mickler wrote:
>
> > Hehe, I know that I wouldn't want to hand edit every autogenerated patch
> > people throw at me... What about just dropping everything before the
> > last "]" or ":" and putting an autogenerated prefix before it in a
> > pre-commit hook on your side?
>
> > That should work most of the time... don't know... maybe other
>
> It's the most of the time bit that worries me, I'm generally reluctant
> to script things like this when the scripts aren't very widely used and
> it's a pain to get hooks distributed over all my systems and working for
> all the things I need to apply patches for.
>
> From my point of view my current approach is actually working pretty
> well with most submitters, even people doing similar janitorial stuff.

I don't know what you asked Joe to change, but asking someone to use
the documented canonical patch format:

<quote>
The canonical patch subject line is:

Subject: [PATCH 001/123] subsystem: summary phrase
</quote>

should be fine. And there is no need for printf-ish templates
for this in MAINTAINERS either.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/