Re: [PATCH 1/3] udf: Replace bkl with the inode->i_alloc_sem forprotect udf_inode_info struct

From: Christoph Hellwig
Date: Tue Nov 16 2010 - 13:05:55 EST


On Tue, Nov 16, 2010 at 06:40:47PM +0100, Alessio Igor Bogani wrote:
> Replace bkl with the inode->i_alloc_sem rw semaphore in udf_release_file(),
> udf_symlink(), udf_symlink_filler(), udf_get_block() and udf_block_map().
> Add protection in udf_evict_inode() using the same i_alloc_sem rw semaphore.

I'd rather prefer not to introduce new users of i_alloc_sem. It's a
quite nasty beast: the only rw_semaphore that is not released by the
thread acquiring it. Thomas asked me if there's a way to get rid of it,
and I've come up with some schemes that I need to prototype. Adding
more uses that are unrelated to the original direct I/O use case are
not very helpful in doing that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/