Re: [PATCH] staging, comedi, das16: das16_attach() needs to free allocated resources on failure

From: Frank Mori Hess
Date: Sun Nov 07 2010 - 18:42:20 EST


On Sunday 07 November 2010, Jesper Juhl wrote:
> Hi,
>
> In drivers/staging/comedi/drivers/das16.c::das16_attach() there are many
> potential failure scenarios. However, the driver neglects to free
> resources it has allocated if failures happen.

This patch appears to be wrong. The driver's detach function will be
called by the core if the attach function returns with an error. The
resources are freed there.

Attachment: signature.asc
Description: This is a digitally signed message part.