Re: [PATCH] perf, ui: Eliminate stack-smashing protection compilercomplain

[Cyrill Gorcunov]

On Sun, Nov 07, 2010 at 10:49:02PM +0100, Frederic Weisbecker wrote:
> On Sat, Nov 06, 2010 at 11:47:24AM +0300, Cyrill Gorcunov wrote:
> >  The gcc complains on Yes, No being allocated from stack space. Make
> > them conts to feel compiler happy.
> > 
> >  |    CC util/ui/util.o
> >  | cc1: warnings being treated as errors
> >  | util/ui/util.c: In function âui__dialog_yesnoâ:
> >  | util/ui/util.c:108: error: not protecting function: no buffer at least 8 bytes long
> >  | make: *** [util/ui/util.o] Error 1
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> > CC: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > CC: FrÃdÃric Weisbecker <fweisbec@xxxxxxxxx>
> > CC: Ingo Molnar <mingo@xxxxxxx>
> > ---
> 
> I hope we can finally queue this one fix, the warning is there
> for a while now, and this patch looks quite sensible :)
> 

yup, thanks for review ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/