Re: [PATCH 1/9] Add yaffs Kconfig and Makefile

From: Ryan Mallon
Date: Thu Nov 04 2010 - 20:13:18 EST


On 11/05/2010 11:36 AM, Greg KH wrote:
> On Fri, Nov 05, 2010 at 09:58:38AM +1300, Charles Manning wrote:
>> On Thursday 04 November 2010 06:46:07 Greg KH wrote:
>>> On Thu, Nov 04, 2010 at 05:53:16AM +1300, cdhmanning@xxxxxxxxx wrote:
>>>> From: Charles Manning <cdhmanning@xxxxxxxxx>
>>>>
>>>> Adding yaffs2 file system.
>>>>
>>>> Signed-off-by: Charles Manning <cdhmanning@xxxxxxxxx>
>>>> ---

>>> Also, is your goal to get this cleaned up good enough to get it into .38
>>> in the "real" place in the kernel, or do you want to see it go through
>>> staging and take a bit longer to get everything cleaned up properly
>>> before moving to the "real" location?
>>
>> My goal it to get this into mainline, .38 preferred.
>>
>> I am a complete newbie when it comes to this process. What's the best
>> path to getting there?
>
> I don't know, both will work.
>
>> My preference is to keep cleaning up code in yaffs.net and patching
>> from there as this will keep the trees closer together and minimise
>> clerical issues.
>
> Sure, but remember, once the code goes into mainline, having an external
> tree is a huge liability, not a benifit at all, so consider dropping it.

The Yaffs codebase also runs on other operating systems. Charles has
cleaned the code up to match the Linux coding style and removed the
support for other operating systems in the patches which he is
attempting to push to mainline.

I believe his intention is to maintain his own, portable, yaffs codebase
which supports Linux and other systems out of tree. There will be some
work for Charles in keeping these two codebases in sync, but that won't
have any visible effect to Linux.

The trick for Charles is to make the Yaffs code which he is submitting
for mainline inclusion clean according to the Linux coding standards,
without creating a maintainence nightmare for himself :-).

~Ryan

--
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@xxxxxxxxxxxxxxxx PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/