Re: [PATCH] Perf, AMD: Prefer kzalloc() over kmalloc()+memset() in amd_alloc_nb()

[Stephane Eranian]

On Mon, Nov 1, 2010 at 6:57 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> On Mon, 1 Nov 2010, Peter Zijlstra wrote:
>
>> On Sat, 2010-10-30 at 21:06 +0200, Jesper Juhl wrote:
>> > Hi,
>> >
>> > I believe this would be an improvement?
>> >
>> > Prefer kzalloc() over kmalloc()+memset() in amd_alloc_nb().
>> >
>> >
>> > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
>> > ---
>>
>>
>> I've changed it to..
>>
>> ---
>> Subject: perf, amd: Use kmalloc_node(,__GFP_ZERO) for northbridge structure allocation
>> From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
>> Date: Mon Nov 01 18:52:05 CET 2010
>>
>> Jasper suggested we use the zeroing capability of the allocators
>> instead of calling memset ourselves. Add node affinity while we're at
>> it.
>>
>> Reported-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
>> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
>
> Fine by me.
>
Works for me.

Acked-by: Stephane Eranian <eranian@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/