Re: [PATCH 20/29] memstick: jmb38x_ms: rework PIO

[Maxim Levitsky]

On Mon, 2010-10-25 at 09:05 -0700, Alex Dubov wrote:
> 
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Subject: [PATCH 20/29] memstick: jmb38x_ms: rework PIO
> > To: "Alex Dubov" <oakad@xxxxxxxxx>
> > Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > Rewrite PIO code to be just simplier
> > and shorter,
> > and comment not so obivous parts.
> > 
> > Signed-off-by: Maxim Levitsky<maximlevitsky@xxxxxxxxx>
> > ---
> 
> Yet, you are fixing something that was not broken before.

A code that is hard to read is broken even if it works, because its very
easy for anyone to break it accidentally.
Anybody disagree (except you)?

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/