Re: [RFC] Restrict size of page_cgroup->flags

[KAMEZAWA Hiroyuki]

On Wed, 6 Oct 2010 19:53:14 +0530
Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> I propose restricting page_cgroup.flags to 16 bits. The patch for the
> same is below. Comments?
> 
> 
> Restrict the bits usage in page_cgroup.flags
> 
> From: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>
> 
> Restricting the flags helps control growth of the flags unbound.
> Restriciting it to 16 bits gives us the possibility of merging
> cgroup id with flags (atomicity permitting) and saving a whole
> long word in page_cgroup
> 
> Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx>

Doesn't make sense until you show the usage of existing bits.
And I guess 16bit may be too large on 32bit systems.

Nack for now.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/