Re: [GIT PULL] one writeback regression fix for .36

[Jens Axboe]

On 2010-10-06 20:17, Linus Torvalds wrote:
> On Wed, Oct 6, 2010 at 9:54 AM, Jens Axboe <jaxboe@xxxxxxxxxxxx> wrote:
>>
>> The recent patch series from Jan introduced a WARN_ON() regression.
>> The real fix for this is adding a super_operations->get_bdi(), which
>> we'll do for 2.6.37.
>>
>> Please pull.
>>
>> are available in the git repository at:
>>  git://git.kernel.dk/linux-2.6-block.git for-linus
>>
>> Christoph Hellwig (1):
>>      writeback: always use sb->s_bdi for writeback purposes
> 
> This is a f*cking disgrace. It's now the second patch I see during
> this release window that works by parsing random strings in the block
> device layer.
> 
> This needs to stop. There's something seriously wrong in the whole
> subsystem. This kind of hackery is a disease, and it seems to be
> endemic.

I'm not enjoying this patch anymore than you are, trust me. As Al
mentioned, it's not as bad as it appears (which is good, because it
appears like a bastard). We could work around this ugliness, but at this
point it'll just be a prettied up turd anyway. So may as well go for the
simple variant of that at least.

> So let's just make sure that 2.6.37 really does clean these things up.
> And dammit, I don't want to see more random crap added. There has been
> too much crazyness going on, with too little taste in the whole
> writeback and IO scheduler area. Jens, you need to put the brakes on.
> No more crap. Really. Make 2.6.37 a stabilization and cleanup release,
> without new crazy features or clever tweaking. Ok? Because writeback
> was a disaster in 2.6.35, and it's been this kind of crazy ugly in
> 2.6.36.
> 
> So I'm not taking any more writeback changes unless I feel that you
> are actively working on cleaning up the crazy tasteless crap without
> adding new code.

Agree, there's no complex stuff queued up for .37. Brakes are on, we do
need a stability release on that side.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/