Re: [PATCH 5/7] oprofile: Abstract the perf-events backend

From: Robert Richter
Date: Wed Oct 06 2010 - 14:34:40 EST


On 04.10.10 16:44:23, Matt Fleming wrote:
> Move the perf-events backend from arch/arm/oprofile into
> drivers/oprofile so that the code can be shared between architectures.
>
> This allows each architecture to maintain only a single copy of the PMU
> accessor functions instead of one for both perf and OProfile. It also
> becomes possible for other architectures to delete much of their
> OProfile code in favour of the common code now available in
> drivers/oprofile/oprofile_perf.c.
>
> Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
> Tested-by: Will Deacon <will.deacon@xxxxxxx>
> ---
> arch/arm/oprofile/Makefile | 4 +
> arch/arm/oprofile/common.c | 319 -------------------------------------
> drivers/oprofile/oprofile_perf.c | 326 ++++++++++++++++++++++++++++++++++++++
> include/linux/oprofile.h | 6 +
> 4 files changed, 336 insertions(+), 319 deletions(-)
> create mode 100644 drivers/oprofile/oprofile_perf.c

This patch looks good.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/