Re: [patch] eicon: make buffer larger

[Armin Schindler]

On Wed, 6 Oct 2010, Dan Carpenter wrote:
> On Wed, Oct 06, 2010 at 10:44:47AM +0200, Armin Schindler wrote:
> > >   927    strcpy (clients[id].drvName,     tmp);
> > >   928    strcpy (clients[id].Dbg.drvName, tmp);
> > >                               ^
> > >                    this buffer is only 16 chars
> >
> > Now I understand. You are right. So the fix would be to change these
> > strcpy() to e.g. strncpy() or similar.
>
> We need more than 16 characters to store the information.  What is the
> problem with just making the buffer larger?

The larger buffer is not really needed. Later versions of the driver will 
use the strcpy/memcpy with checked size anyway.
I just want to avoid a change in the debug structure which is used in more than one module/tool.

But it shouldn't be a real problem.

Armin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/