Re: [V9fs-developer] [PATCH 1/3] fs/9p: Update TLCREATE to allow create without open

[Aneesh Kumar K. V]

On Tue, 5 Oct 2010 13:15:42 -0400, Eric Van Hensbergen <ericvh@xxxxxxxxx> wrote:
> Ouch.  Protocol change.
> 
> Also - not sure I understand what's going on here.  Why does mknod go
> through TLCREATE, shouldn't we have our
> own protocol messages for mknod?//

This is needed for the below mknod usage

mknod("k2", S_IFREG) ;


> 
> Why add an additional flag field instead of just using the existing
> flags field since we are only talking about a bit?
> 

TLCREATE is 

  size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4]
    
  size[4] Rlcreate tag[2] qid[13] iounit[4]
    

The flags argument represent Linux access mode flags with which the caller
is requesting to open the file with. Protocol allows all the Linux
access

Having a -1 with the flag would indicate all the access mode flags are
set. So i found that to be ugly. And value 0 indicate O_RDONLY. So was
not sure whether -1 in flags or having a separate lookup flags is the
right thing to do.

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/