Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35

[Masayuki Ohtake]

Hi David,

On Wednesday, October 06, 2010 3:45 AM, David Miller wrote,
> We encourage all new drivers that can use NAPI to do so, just because
> recent driver submissions do not do this doesn't mean we should
> continue such a mistake ;-)

I understand NAPI's merit.
But, since we have already implemented without NAPI.
If possible, we don't want to use NAPI.

Does your mail mean, for accepting upstream, NAPI is essential for CAN driver ?
If essential, we will just do.

Thanks, Ohtake(OKISemi)
----- Original Message ----- 
From: "David Miller" <davem@xxxxxxxxxxxxx>
To: <masa-korg@xxxxxxxxxxxxxxx>
Cc: <mkl@xxxxxxxxxxxxxx>; <sameo@xxxxxxxxxxxxxxx>; <chripell@xxxxxxxx>; <meego-dev@xxxxxxxxx>;
<morinaga526@xxxxxxxxxxxxxxx>; <joel.clark@xxxxxxxxx>; <kok.howg.ewe@xxxxxxxxx>; <socketcan-core@xxxxxxxxxxxxxxxx>;
<yong.y.wang@xxxxxxxxx>; <linux-kernel@xxxxxxxxxxxxxxx>; <netdev@xxxxxxxxxxxxxxx>; <margie.foster@xxxxxxxxx>;
<qi.wang@xxxxxxxxx>; <andrew.chih.howe.khor@xxxxxxxxx>; <wg@xxxxxxxxxxxxxx>
Sent: Wednesday, October 06, 2010 3:45 AM
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35


> From: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>
> Date: Tue, 5 Oct 2010 21:09:30 +0900
>
> > On Tuesday, October 05, 2010 8:08 PM, Marc Kleine-Budde wrote:
> >> If FIFO is working you might also think about NAPI.
> >
> > I think NAPI isn't necessary for our CAN driver.
> > NAPI is for high-speed networking.
> > CAN is NOT high-speed.
> >
> > In fact, some accepted CAN drivers don't have NAPI.
>
> NAPI is not just for performance concerns.
>
> It greatly simplifies the locking since all packet processing paths
> run only in software interrupt context, never in hardware interrupt
> context.
>
> We encourage all new drivers that can use NAPI to do so, just because
> recent driver submissions do not do this doesn't mean we should
> continue such a mistake ;-)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/