Re: [RESEND] [PATCH] Input: add appleir USB driver

From: Dmitry Torokhov
Date: Tue Oct 05 2010 - 11:56:10 EST


On Tue, Oct 05, 2010 at 08:18:35AM +0200, Oliver Neukum wrote:
> Am Dienstag, 5. Oktober 2010, 08:08:22 schrieb Dmitry Torokhov:
> > > But what about the next opener? He'll get a completely spurious
> > > key release event, as the next key is pressed.
> >
> > How does the opening of a device handle relate to a device state?
>
> It doesn't.
>
> > Userspace should expect to see releases without presses (in case they
> > weren't the first client that opened the device).
>
> Yes, but based on sane timing. From the time stamps user space
> would conclude that the key had been pressed at an unknown time
> before open and released at the time the event indicates. Possibly
> it would compute that the key had been held for at least hours.
>

I do not understand. If a client never seen the "press" event and only
saw "release" event it can't make any assumptions about timing. Press
could be a millisecond ago or an hour ago, it just does not know. And
such scenario can easily happen if the client is second to open the
device.

I think the only sane behavior for clients is to ignore release events
for keys that they did not see "down" event for.

-
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/