Re: [PATCH] x86, cpu: Fix X86_FEATURE_NOPL

[Borislav Petkov]

From: "H. Peter Anvin" <hpa@xxxxxxxxx>
Date: Mon, Oct 04, 2010 at 02:53:15PM -0700

> On 10/04/2010 02:48 PM, Borislav Petkov wrote:
> > 
> > I think the cleanup should be easy: on 64-bit unconditionally return
> > p6_nops in find_nop_table() since every 64-bit processor should support
> > them and on 32-bit never return p6_nops since X86_FEATURE_NOPL is not
> > set there and fall back to intel_nops on non-AMD. Which means we can get
> > rid of X86_FEATURE_NOPL altogether. Too radical?
> > 
> 
> FWIW, if P6_NOPs work as well as 66...90 on AMD,

Yeah, let me get back to you on that :).

>  I'd much rather switch to the fixed sequence for all 64-bit
> processors.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/