Re: [patch 1/2] security: add const to security_task_setscheduler()

From: KOSAKI Motohiro
Date: Mon Oct 04 2010 - 21:55:58 EST


> On Fri, 1 Oct 2010, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>
> > From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> >
> > All security modules shouldn't change sched_param parameter of
> > security_task_setscheduler(). This is not only meaningless, but also make
> > harmful result if caller pass static variable.
>
> Nobody's using this parameter, so probably best to just get rid of it in
> the LSM API.

To be honest, I don't like completely remove this parameter because
security_task_setscheduler(struct task_struct *p) seems not so useful.

But, you are maintainer. OK, I've reworked this as you requested :-)

Thanks.