Re: [PATCH] x86: Reenable the AMD IOMMU if it's mysteriouslyvanished over suspend

[Roedel, Joerg]

On Mon, Oct 04, 2010 at 09:55:52AM -0400, Matthew Garrett wrote:
> On Mon, Oct 04, 2010 at 03:43:39PM +0200, Roedel, Joerg wrote:
> > 
> > Why have you moved this out of the enable_iommus() loop?
> 
> enable_iommus() is called on init, whereas this should only be performed 
> on resume.

Ok, it shouldn't be problematic to do this always, but only on resume is
safer.  Can you rename iommu_apply_quirks to iommu_apply_resume_quirks
then?

> I'll send out an updated patch later today.

Great. Looking forward to it.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/