Re: gas 2.16 and assembly macros -- entry_64.S build failure

From: Jan Beulich
Date: Mon Oct 04 2010 - 03:36:39 EST


>>> On 01.10.10 at 19:21, "H. Peter Anvin" <hpa@xxxxxxxxx> wrote:
> On 10/01/2010 08:46 AM, Jan Beulich wrote:
>>
>> Perhaps a misunderstanding? I meant to move the % back into
>> movq_cfi's arguments, out of the macro body. pushq_cfi already
>> is in the shape we need for having the option of using cpp macros
>> when !CONFIG_AS_CFI.
>>
>
> Hm... I guess I'm not quite following. I don't really see how that
> would help with movq_cfi, though?

Oh, sorry, I overlooked that the macro is also attaching (%rsp)
to the second operand. So what I said would only apply to
movq_cfi_restore (where \offset really isn't used without the
(%rsp), and hence this can also be moved back out of the macro
body).

For movq_cfi it may require some playing with .irpc to achieve the
same (due to there not being any string manipulation operations
in gas). I'm pretty sure it can be made work, but it'll look ugly
(and/or may require insertion of a space between the offset
expression and the (%rsp)).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/