Re: [PATCH] regulator: max8649 - fix setting extclk_freq

[Liam Girdwood]

On Fri, 2010-10-01 at 10:36 -0700, Mark Brown wrote:
> On Fri, Oct 01, 2010 at 07:18:14PM +0800, Axel Lin wrote:
> > 2010/10/1 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
> 
> > > Are there existing users of the driver?  It's not always 100% clear if
> > > people are expecting bitfield values that will be shifted in or values
> > > that can be ored directly in.  I don't really mind either way but I'd
> > > rather be careful.
> 
> > I think I should explain this way:
> 
> > In max8649.h , we have
> > enum {
> >         MAX8649_EXTCLK_26MHZ = 0,
> >         MAX8649_EXTCLK_13MHZ,
> >         MAX8649_EXTCLK_19MHZ,   /* 19.2MHz */
> > };
> 
> OK, that's clearer.  When changing the interpretation of existing
> platform data like this it's good to note this sort of thing in the
> changelog since merge issues can be a real pain.
> 
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> --

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/