Re: [PATCH 3/4] mfd/mc13xxx: add support for mc13892

From: Samuel Ortiz
Date: Fri Oct 01 2010 - 06:42:37 EST


Hi Uwe,

On Wed, Sep 29, 2010 at 06:23:46PM +0200, Uwe Kleine-König wrote:
> mc13892 is the companion PMIC for Freescale's i.MX51. It's similar enough
> to mc13782 to support it in a single driver.
>
> This patch introduces enough compatibility cruft to keep all users of the
> superseded mc13783 driver unchanged.
All 4 patches applied, thanks.

I have one comment though:

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index db51ea1..1868d9b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -408,11 +408,16 @@ config MFD_PCF50633
> so that function-specific drivers can bind to them.
>
> config MFD_MC13783
> - tristate "Support Freescale MC13783"
> + tristate
> +
I don't think it's worth keeping this symbol around.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/