Re: [PATCH v2] HID: magicmouse: Use hid-input parsing rather thanbypassing it

From: Michael Poole
Date: Thu Sep 23 2010 - 19:44:11 EST


On Thu, Sep 23, 2010 at 9:20 AM, Chase Douglas
<chase.douglas@xxxxxxxxxxxxx> wrote:
> On Thu, 2010-09-23 at 08:15 -0400, Michael Poole wrote:
>> Let the HID core handle input device setup and HID-compliant reports.
>> This driver then only has to worry about the non-standard reports.
>>
>> Signed-off-by: Michael Poole <mdpoole@xxxxxxxxxxx>
>
> Michael, do you need me to retest the patch? I haven't looked at this
> second version, but if it's pretty much as you describe below and you
> don't need me to test it again, then my ACK still stands.
>
> Thanks,
>
> -- Chase

The behavior will be 100% identical for currently supported devices,
so I don't see any real benefit in you re-testing it. I just didn't
want to assume (without checking) that your ack was valid for the
revised version.

Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/