Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10

[Dan Williams]

On Wed, Sep 1, 2010 at 8:24 AM, Linus Walleij
<linus.walleij@xxxxxxxxxxxxxx> wrote:
> This extends the PL022 SSP/SPI driver with generic DMA engine
> support using the PrimeCell DMA engine interface. Also fix up the
> test code for the U300 platform.
>
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> ---
> As mentioned I have no clue to why this failed to compile for Grant,
> please see if this tenth version is still problematic or if it was
> something intermittent.
>
> Else I really need help in knowing what config to compile, this was
> compiled for U300, U8500 and RealView with and without DMA enabled.

Maybe it makes more sense for these filter_id functions to be defined
in the arch code rather than the dma driver.  Right now there seems to
be a weird dependency of arch requires dma-driver, dma-driver requires
arch, and slave-driver requires arch and dma-driver in order to
dynamically select dma-driver with dma_request_channel().  It forces
dma-driver and slave-driver to always be compiled in, if I am reading
this correctly.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/