Re: mmotm 2010-09-22 - build error in drivers/staging/zram

From: Andrew Morton
Date: Wed Sep 22 2010 - 23:42:51 EST


On Wed, 22 Sep 2010 23:26:06 -0400 Valdis.Kletnieks@xxxxxx wrote:

> On Wed, 22 Sep 2010 16:12:09 PDT, akpm@xxxxxxxxxxxxxxxxxxxx said:
> > The mm-of-the-moment snapshot 2010-09-22-16-11 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Looks like zram-free-percpu-data-on-module-exit.patch has issues:
>
> CC [M] drivers/staging/zram/zram_drv.o
> drivers/staging/zram/zram_drv.c: In function 'zram_reset_device':
> drivers/staging/zram/zram_drv.c:500:2: error: incompatible type for argument 1 of 'free_percpu'
> include/linux/percpu.h:153:13: note: expected 'void *' but argument is of type 'struct zram_stats'
> make[3]: *** [drivers/staging/zram/zram_drv.o] Error 1
>

bah. `make allmodconfig' enables CONFIG_STAGING_EXCLUDE_BUILD, so
nothing under staging gets built. Seems rather dumb.

zram-free-percpu-data-on-module-exit.patch seems to be unneeded in the
current zram driver - I'll drop the patch, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/