Re: [PATCH 2/2] Rewrite jump_label.c to use binary search

[Mathieu Desnoyers]

* Andi Kleen (andi@xxxxxxxxxxxxxx) wrote:
> 
> >
> >>> +	for (; entry < stop && entry->key == key; entry++)
> >>> +		if (kernel_text_address(entry->code))
> >>
> >> This does not work for modules I'm afraid, only for the core kernel. You
> >> should test for __module_text_address() somewhere.
> >
> > I thought it was shared now, but ok.
> 
> Double checked. This is ok because kernel_text_address()
> already checks for modules. You were probably thinking
> of __kernel_text_address()

Ah right,

Although we have another problem:

__module_text_address() includes module init text, which defeats the
purpose of the check put in there by Jason.

So the check works for the core kernel, but not for modules.

Mathieu

> 
> -Andi
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/