Re: [PATCH 2/2] Rewrite jump_label.c to use binary search

[Jason Baron]

On Wed, Sep 22, 2010 at 01:56:48PM +0200, Andi Kleen wrote:
> 
> >> +	for (; entry < stop && entry->key == key; entry++)
> >> +		if (kernel_text_address(entry->code))
> >
> > This does not work for modules I'm afraid, only for the core kernel. You
> > should test for __module_text_address() somewhere.
> 
> I thought it was shared now, but ok.
> 
> > Dumb question: why do you need this test at all ?
> 
> I just copied that from the original code. In fact I was wondering
> too why it's needed. Jason?
> 
> 

It was put there for jump labels that are in __init sections. Without 
this check the code will corrupt itself when we toggle a jump label 
after the __init sections have been freed.

thanks,

-Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/