Re: [PATCH] Add sc16is7x2 driver

[Manuel Stahl]

Am 21.09.2010 22:42, schrieb Greg KH:
> On Tue, Sep 14, 2010 at 03:07:13PM +0200, Manuel Stahl wrote:
> > --- a/include/linux/serial_core.h
> > +++ b/include/linux/serial_core.h
> > @@ -47,6 +47,9 @@
> >   #define PORT_U6_16550A	19	/* ST-Ericsson U6xxx internal UART */
> >   #define PORT_MAX_8250	19	/* max port ID */
> >
> > +/* SC16IS7x2 SPI UART */
> > +#define PORT_SC16IS7X2	19
>
> Hm, didn't you just duplicate the number here?  Shouldn't that be "20"
> and you bump the max up?

Oh, that might be true.

> In the end, we need to just drop those, I don't think we need defines
> anymore, but I need to look at it some more to find out.

Thank you for doing that, Greg.

Regards,
--
Dipl.-Inf. Manuel Stahl
Fraunhofer-Institut für Integrierte Schaltungen IIS
- Leistungsoptimierte Systeme -
Nordostpark 93                Telefon  +49 (0)911/58061-6419
90411 Nürnberg                Fax      +49 (0)911/58061-6398
http://www.iis.fraunhofer.de  manuel.stahl@xxxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/