Re: [PATCH] fsldma: add support to 36-bit physical address

From: Scott Wood
Date: Tue Sep 21 2010 - 17:35:12 EST


On Tue, 21 Sep 2010 16:24:10 -0500
Timur Tabi <timur.tabi@xxxxxxxxx> wrote:

> On Tue, Sep 21, 2010 at 7:55 AM, Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Sep 21, 2010, at 5:57 AM, Li Yang wrote:
> >
> >> Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>
> >> ---
> >
> > We really should have a sentence about how or why this works to address 36-bit addressing.
>
> For example, I would like to know which memory is going to be
> allocated above 4GB. I don't know much about the kernel's async
> library, but my understanding is that fsldma does not allocate any of
> the memory buffers that it copies data to/from.

This doesn't control allocation (it probably should with
dma_alloc_coherent, though I don't see it in the code), it controls
whether swiotlb will create a bounce buffer -- defeating the point of
using DMA to accelerate a memcpy.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/