Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introducedby libahci split

[Michael Tokarev]

21.09.2010 11:25, Tejun Heo wrote:
> libata depends on scsi_host_template for module reference counting and
> sht's should be owned by each low level driver.  During libahci split,
> the sht was left with libahci.ko leaving the actual low level drivers
> not reference counted.  This made ahci and ahci_platform always
> unloadable even while they're being actively used.
> 
> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for
> each low level ahci driver.
> 
> stable: only applicable to 2.6.35.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Michael Tokarev <mjt@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxx
> ---
> Michael, thanks a lot for spotting it and bearing with me.

Um.  All thanks goes to Pedro Francisco please, not to me -
I just verified your patch on my system, it was Pedro who spotted
and reported this.  You may add my

 Tested-Off-By: Michael Tokarev <mjt@xxxxxxxxxx>

, but not Reported-by... please ;)

Thanks!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/