Re: [PATCH] x86/mrst: add SFI platform device parsing code

[Mark Brown]

On Mon, Sep 20, 2010 at 03:01:06PM +0100, Alan Cox wrote:

> +static void *max3111_platform_data(void *info)
> +{
> +	static int dummy;
> +	struct spi_board_info *spi_info = (struct spi_board_info *)info;
> +	int intr = get_gpio_by_name("max3111_int");

> +/* we have multiple max7315 on the board ... */
> +#define MAX7315_NUM 2
> +static void *max7315_platform_data(void *info)

> +static void *emc1403_platform_data(void *info)
> +{

> +static void *lis331dl_platform_data(void *info)
> +{
> +	static short intr2nd_pdata;
> +	struct i2c_board_info *i2c_info = (struct i2c_board_info *)info;

It's rather concerning that the parser here needs to have all this
knowledge about the specific chips that will be on the boards.  Is there
a plan for how this will be managed once system integrators begin
putting other chips onto Moorestown boards?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/