Re: [PATCH] Regulator: lp3972 cleanup

[Liam Girdwood]

On Fri, 2010-09-17 at 13:28 +0100, Mark Brown wrote:
> On Fri, Sep 17, 2010 at 01:44:17PM +0800, Axel Lin wrote:
> 
> >  - Logging the value for diagnostics if failed to detect device
> 
> >  	if (ret == 0 && (val & SYS_CONTROL1_INIT_MASK) != SYS_CONTROL1_INIT_VAL)
> >  		ret = -ENODEV;
> >  	if (ret < 0) {
> > -		dev_err(&i2c->dev, "failed to detect device\n");
> > +		dev_err(&i2c->dev, "failed to detect device: %d\n", ret);
> 
> This misses part of the point of my suggestion - if you don't match the
> ID register then you'll log -ENODEV rather than the device ID that you
> read back which would presumably be more useful for someone trying to
> work out why the check triggered.
> 
> Lots of other good stuff in there, though:
> 
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/