Re: [PATCH] alpha: fix build breakage in asm/cacheflush.h

From: Matt Turner
Date: Sun Sep 19 2010 - 00:52:42 EST


On Tue, Sep 14, 2010 at 5:00 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Alpha SMP flush_icache_user_range() is implemented as an inline
> function inside include/asm/cacheflush.h.  It dereferences @current
> but doesn't include linux/sched.h and thus causes build failure if
> linux/sched.h wasn't included previously.  Fix it by including the
> needed header file explicitly.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
>  arch/alpha/include/asm/cacheflush.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/cacheflush.h b/arch/alpha/include/asm/cacheflush.h
> index 01d71e1..012f124 100644
> --- a/arch/alpha/include/asm/cacheflush.h
> +++ b/arch/alpha/include/asm/cacheflush.h
> @@ -43,6 +43,8 @@ extern void smp_imb(void);
>  /* ??? Ought to use this in arch/alpha/kernel/signal.c too.  */
>
>  #ifndef CONFIG_SMP
> +#include <linux/sched.h>
> +
>  extern void __load_new_mm_context(struct mm_struct *);
>  static inline void
>  flush_icache_user_range(struct vm_area_struct *vma, struct page *page,

Thanks! Applied this to my tree and sent it to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html