Re: [PATCH] VMware Balloon: rename module

[Dmitry Torokhov]

Hi Chetan,

On Thursday, September 16, 2010 04:05:28 pm Chetan Loke wrote:
> > From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Dmitry Torokhov
> > Sent: September 16, 2010 6:01 PM
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: pv-drivers@xxxxxxxxxx; Andrew Morton
> > Subject: [PATCH] VMware Balloon: rename module
> > 
> > 
> > 
> > In an effort to minimize customer confusion we want to unify naming
> > convention for VMware-provided kernel modules. This change renames
> > the balloon driver from vmware_ballon to vmw_balloon.
> 
> What will vmtools name its vmware_balloon driver to? vmw_balloon, correct?

That is the plan.

> 
> > +	vmballoon_wq = create_freezeable_workqueue("vmmemctl");
> 
> minor change - vmware_vmmemctl?

I do not think this needs to be changed; it does not have to match
the module name, plus, given Tejun's changes, it will all be generic
[worker/u:X] soon anyway.

> 
> I might've seen a debugfs entry too.

I still plan on keeping it as "vmmemctl" so we do not have to change
scripts too often. The move in module names prompted by complaints
that name changes when user requests tools to clobber distribution-
provided modules.

> 
> 
> side note - is it possible to extend the balloon driver to get a
> notification on other events? like CPUs, NICs? Just an event is what
> I'm looking for. No action need to be taken in the guest.

No, balloon driver should be limited to ballooning. I think the data
you are looking for can be retrieved via GuestSDK (and I believe we
are adding balloon_target to the available data).

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/