Re: [PATCH] drivers:staging:ti-st: mv headers to ti_wilink_st

From: Greg KH
Date: Thu Sep 16 2010 - 18:49:39 EST


On Thu, Sep 16, 2010 at 06:34:04PM -0400, pavan_savoy@xxxxxx wrote:
> From: Pavan Savoy <pavan_savoy@xxxxxx>
>
> move all the header information to ti_wilink_st.h.
> This header would then not only serve the local modules like the st_core.c,
> st_kim.c and st_ll.c but also the external modules/protocol drivers that are
> dependent on the shared transport driver.
> Also modify the structures to use cleaner u8/u16 types for data coming
> in from chip and data parsed out of firmware.

No!

Don't do more than one thing at once please, do one thing at a time.

One patch to modify the structures.

And one patch to move things together.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/