RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

From: Xin, Xiaohui
Date: Sat Sep 11 2010 - 05:42:54 EST


>>> +
>>> + if (ctor->lock_pages + count > lock_limit && npages) {
>>> + printk(KERN_INFO "exceed the locked memory rlimit.");
>>> + return NULL;
>>> + }
>>> +
>>> + info = kmem_cache_zalloc(ext_page_info_cache, GFP_KERNEL);
>>
>>You seem to fill in all memory, why zalloc? this is data path ...
>
>Ok, Let me check this.

It's mainly for info->next and info->prev, these two fields will be used in hash functions.
But you are right, since most fields will be refilled. The new version includes the fix.

Thanks
Xiaohui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/