Re: [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform

[Mark F. Brown]

On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> Dne St 8. zÃÅÃ 2010 04:56:45 Mark F. Brown napsal(a):
>
> ---------------------------
> Description is missing here
> ---------------------------
>
>> Signed-off-by: Mark F. Brown <mark.brown314@xxxxxxxxx>
>> ---
>> Âarch/arm/mach-mmp/Kconfig   |  Â7 ++++++
>> Âarch/arm/mach-mmp/Makefile  Â|  Â1 +
>> Âarch/arm/mach-mmp/teton_bga.c | Â 47
>> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
>> insertions(+), 0 deletions(-)
>> Âcreate mode 100644 arch/arm/mach-mmp/teton_bga.c
>>
>> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> index 6ab843e..0711d3b 100644
>> --- a/arch/arm/mach-mmp/Kconfig
>> +++ b/arch/arm/mach-mmp/Kconfig
>> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
>> Â Â Â Â PXA910-based development board. Since MMP2 is compatible to
>> Â Â Â Â ARMv6 architecture.
>>
>> +config MACH_TETON_BGA
>> + Â Â bool "Marvell's PXA168 Teton BGA Development Board"
>> + Â Â select CPU_PXA168
>> + Â Â help
>> + Â Â Â Say 'Y' here if you want to support the Marvell PXA168-based
>> + Â Â Â Teton BGA Development Board.
>> +
>> Âendmenu
>>
>> Âconfig CPU_PXA168
>> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
>> index 8b66d06..751cdbf 100644
>> --- a/arch/arm/mach-mmp/Makefile
>> +++ b/arch/arm/mach-mmp/Makefile
>> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
>> Âobj-$(CONFIG_MACH_TTC_DKB) Â += ttc_dkb.o
>> Âobj-$(CONFIG_MACH_FLINT) Â Â += flint.o
>> Âobj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
>> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
>> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
>> new file mode 100644
>> index 0000000..014cc37
>> --- /dev/null
>> +++ b/arch/arm/mach-mmp/teton_bga.c
>> @@ -0,0 +1,47 @@
>> +/*
>> + * Âlinux/arch/arm/mach-mmp/teton_bga.c
>> + *
>> + * ÂSupport for the Marvell PXA168 Teton BGA Development Platform.
>
> Authoring information of this file are missing. Also, MAINTAINERS entry is
> missing.
>> + *
>> + * ÂThis code is based on aspenite.c
>> + *
>> + * ÂThis program is free software; you can redistribute it and/or modify
>> + * Âit under the terms of the GNU General Public License version 2 as
>> + * Âpublishhed by the Free Software Foundation.
>> + */
>> +
>> +#include <linux/init.h>
>> +#include <linux/kernel.h>
>> +#include <linux/platform_device.h>
>> +
>> +#include <asm/mach-types.h>
>> +#include <asm/mach/arch.h>
>> +#include <mach/addr-map.h>
>> +#include <mach/mfp-pxa168.h>
>> +#include <mach/pxa168.h>
>> +#include <mach/gpio.h>
>
> use ... #include <linux/gpio.h>
>
>> +
>> +#include "common.h"
>> +
>> +static unsigned long teton_bga_pin_config[] __initdata = {
>> + Â Â /* UART1 */
>> + Â Â GPIO107_UART1_TXD,
>> + Â Â GPIO108_UART1_RXD,
>> +};
>> +
>> +static void __init teton_bga_init(void)
>> +{
>> + Â Â mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
>> +
>> + Â Â /* on-chip devices */
>> + Â Â pxa168_add_uart(1);
>
> Don't we have enum for these magic numbers on pxa168 ?
>> +}
>> +
>> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
>> +   .phys_io    Â= APB_PHYS_BASE,
>> +   .io_pg_offst  Â= (APB_VIRT_BASE >> 18) & 0xfffc,
>> +   .map_io     = mmp_map_io,
>> +   .init_irq    = pxa168_init_irq,
>> +   .timer     Â= &pxa168_timer,
>> +   .init_machine  = teton_bga_init,
>> +MACHINE_END
>
> Cheers
>

I am assuming you mean the magic number for .io_pg_offst:
 .io_pg_offst  Â= (APB_VIRT_BASE >> 18) & 0xfffc,

It seems all of the other platforms in arch/arm are configuring it
this way. Do you really want me to change this?

Regards,
-- Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/