Re: [PATCH] AT91: SAM9G45 - add a separate clock entry for everysingle TC block

[avictor.za@xxxxxxxxx]

hi,

> +/* One additional fake clock for second TC block */
> +static struct clk tcb1_clk = {
> +       .name           = "tcb1_clk",
> +       .pmc_mask       = 0,
> +       .type           = CLK_TYPE_PERIPHERAL,
> +       .parent         = &tcb0_clk,
> +};
> +

Looking at this again...  since type is CLK_TYPE_PERIPHERAL, when you
call clk_register() the "parent" is changed to the master clock.

Which means, then later you call clk_enable() the "pmc_mask" is still
0, so 0 gets written (in pmc_periph_mode) to AT91_PMC_PCER.  So the
TCB clock won't be enabled.

Or am I missing something?


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/