RE: [PATCH] USB: Fix kernel oops with g_ether and Windows
From: Gadiyar, Anand
Date: Tue Sep 07 2010 - 06:49:13 EST
Maxim Osipov wrote:
> On Tue, Sep 7, 2010 at 1:55 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> >
> > Â It was caught by me on the list too, right at the same day the patch was
> > posted. The author remained silent though...
> >
Sorry Sergei, I seem to have missed your mail on the list, and didn't
bother hunting in the list archives.
>
> Sorry for being silent - I had lots of things to do. Regarding the
> patch itself - I respect kernel coding conventions, but I think it is
> bad to have two different code styles in one file. Note, this is my
> personal opinion only.
>
I should have looked closer - I see now that you've only retained
the existing style.
Since Greg has already sent a pull request, I won't touch the file
now; maybe a trivial patch later on to fix up the coding style.
- Anand
N§²æìr¸yúèØb²X¬¶ÇvØ^)Þ{.nÇ+·¥{±êçzX§¶¡Ü}©²ÆzÚ&j:+v¨¾«êçzZ+Ê+zf£¢·h§~Ûiÿûàz¹®w¥¢¸?¨èÚ&¢)ßfù^jÇy§m
á@A«a¶Úÿ0¶ìh®åi