Re: Important news regarding the two different patches

From: Rafael J. Wysocki
Date: Mon Sep 06 2010 - 14:44:38 EST


On Monday, September 06, 2010, M. Vefa Bicakci wrote:
> On 05/09/10 10:08 PM, KOSAKI Motohiro wrote:
> >>> ok, thanks. probably I've catched your point. please feel free to use my reviewed-by
> >>> for your fix.
> >>
> >> Thanks.
> >>
> >> In the meantime, though, I prepared a patch that should address the issue
> >> entirely. The patch is appended and if it looks good to you, I'd rather use it
> >> instead of the previous one (it is still untested).
> >
> > Yeah, this one looks nicer to me :)
> >
> > Thanks, rafael!
>
> Dear Rafael Wysocki, Kosaki Motohiro and Minchan Kim,
>
> Upon Kosaki Motohiro's kind request via an off-list e-mail,
> I tested the following two patches separately with a vanilla
> 2.6.35.4 kernel:
>
> Patch 1:
> http://lkml.org/lkml/2010/9/5/86
>
> Patch 2:
> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/4/4615426
>
> The first of these was prepared by Minchan Kim, and it fixes
> the issue; i.e. no hangs during hibernation with a full tmpfs.

We've already agreed that this patch should be applied.

> However, the second patch, prepared by Rafael Wysocki, does *not*
> fix the problem. I still experience hangs with a full tmpfs upon
> hibernation.

So we still manage to trigger OOM with this approach.

> As always, I am willing to test newer patches and help in debugging
> this issue.

What happens if you apply them both at the same time?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/