Re: [PATCH 2/3] M68K: Use CONFIG_MMU not __uClinux__ to selectm68knommu contributions

[Sam Ravnborg]

On Thu, Sep 02, 2010 at 04:12:38PM +0100, David Howells wrote:
> Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> 
> > This was exactly the reason why __uClinux__ was used in the first place.
> 
> That shouldn't be used in kernel headers.  It should be !CONFIG_MMU.

Thats preferable - yes.
But in headers that are exported we cannot rely on CONFIG_MMU,
and Andreas could point out two headers that are exported
where your patch replaced __uClinux__ with CONFIG_MMU.

Thats wrong.
I assume you aggree on this?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/