Re: [PATCH 4/4] Enabling Ethernet support for LogicPD's OMAP3530LV SOM and OMAP 35x Torpedo dev board

[Russell King - ARM Linux]

On Tue, Aug 24, 2010 at 11:53:40PM -0400, Jacob Tanenbaum wrote:
> +static inline void __init board_smsc911x_init(void)
> +{
> +	/* OMAP3530 LV SOM board */
> +	if (machine_is_omap3530_lv_som()) {
> +		board_smsc911x_data.gpio_irq =
> +					OMAP3530_LV_SOM_SMSC911X_GPIO_IRQ;
> +		/* board_smsc911x_data.gpio_reset
> +			driven by SYS_nRESWARM, no GPIO */
> +		/* omap_cfg_reg(AE1_34XX_GPIO152_UP); */
> +		omap_mux_init_signal("gpio_152", OMAP_PIN_INPUT);
> +
> +/* omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT);*/
> +
> +	/* OMAP3 Torpedo board */

missing tab?  Maybe it would make sense to put this after the line below?

> +	} else if (machine_is_omap3_torpedo()) {
> +		board_smsc911x_data.gpio_irq = OMAP3_TORPEDO_SMSC911X_GPIO_IRQ;
> +		/* board_smsc911x_data.gpio_reset driven
> +			by SYS_nRESWARM, no GPIO */
> +		/*omap_cfg_reg(AE1_34XX_GPIO152_UP);*/
> +		omap_mux_init_signal("gpio_129", OMAP_PIN_INPUT);
> +		/* TODO/FIXME (comment by Peter Barada, LogicPD):
> +		* On Torpedo, LAN9221 IRQ is an MMC1_DATA7 pin
> +		* and IRQ1760 IRQ is MMC1_DATA4 pin - need
> +		* to update PBIAS to get voltage to the device
> +		* so the IRQs works correctly rather than float
> +		* and cause an IRQ storm...
> +								*/
> +		omap3torpedo_fix_pbias_voltage();
> +	/* unsupported board */

missing tab?  or maybe it should be moved after the line below.

> +	} else {
> +		printk(KERN_ERR "%s(): unknown machine type\n", __func__);
> +		return;
> +	}
> +	gpmc_smsc911x_init(&board_smsc911x_data);
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/