Re: [PATCH] HID: roccat: Normalized reported profile number for pyrabutton events.

From: Jiri Kosina
Date: Wed Sep 01 2010 - 06:43:17 EST


On Mon, 30 Aug 2010, Stefan Achatz wrote:

> Pyra uses profile numbers in range 0-4 for everything except button
> events. Using range 1-5 consistent now.
>
> Signed-off-by: Stefan Achatz <erazor_de@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/hid/hid-roccat-pyra.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-roccat-pyra.c
> b/drivers/hid/hid-roccat-pyra.c
> index 6c09c15..9bf2304 100644
> --- a/drivers/hid/hid-roccat-pyra.c
> +++ b/drivers/hid/hid-roccat-pyra.c
> @@ -902,7 +902,11 @@ static void pyra_report_to_chrdev(struct
> pyra_device const *pyra,
> if (button_event->data2 == PYRA_MOUSE_EVENT_BUTTON_PRESS) {
> roccat_report.type = button_event->type;
> roccat_report.key = button_event->data1;
> - roccat_report.value = pyra->actual_profile;
> + /*
> + * pyra reports profile numbers with range 1-5.
> + * Keeping this behaviour.
> + */
> + roccat_report.value = pyra->actual_profile + 1;
> roccat_report_event(pyra->chrdev_minor,
> (uint8_t const *)&roccat_report,
> sizeof(struct pyra_roccat_report));

Applied.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/