Re: [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: Remove double test

[Thomas Dahlmann]

David Brownell schrieb:
> --- On Sat, 8/28/10, Julia Lawall <julia@xxxxxxx> wrote:
>
>   
> > From: Julia Lawall <julia@xxxxxxx>
> > Subject: Re: [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: Remove double test
> > To: "Dan Carpenter" <error27@xxxxxxxxx>
> > Cc: "Thomas Dahlmann" <dahlmann.thomas@xxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, "David Brownell" <dbrownell@xxxxxxxxxxxxxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxx>, linux-geode@xxxxxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> > Date: Saturday, August 28, 2010, 9:48 AM
> > The same expression is tested twice
> > and the result is the same each time.
> > Instead test for use_dma_ppb as in the test above.
> >
> > The sematic match that finds this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @expression@
> > expression E;
> > @@
> >
> > (
> > * E
> >   || ... || E
> > |
> > * E
> >   && ... && E
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
> >     
>
>
> OK by me unless the maintainer/author objects.
>
> Thank you!
>
> - Dave
>
>   

This fix is OK. Thank you for figuring this out!

- Thomas

>   
> > ---
> >  drivers/usb/gadget/amd5536udc.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/amd5536udc.c
> > b/drivers/usb/gadget/amd5536udc.c
> > index 731150d..6c40c99 100644
> > --- a/drivers/usb/gadget/amd5536udc.c
> > +++ b/drivers/usb/gadget/amd5536udc.c
> > @@ -203,7 +203,7 @@ static void print_regs(struct udc
> > *dev)
> >          DBG(dev, "DMA
> > mode       = PPBNDU (packet per
> > buffer "
> >             
> > "WITHOUT desc. update)\n");
> >         
> > dev_info(&dev->pdev->dev, "DMA mode (%s)\n",
> > "PPBNDU");
> > -    } else if (use_dma &&
> > use_dma_ppb_du && use_dma_ppb_du) {
> > +    } else if (use_dma &&
> > use_dma_ppb && use_dma_ppb_du) {
> >          DBG(dev, "DMA
> > mode       = PPBDU (packet per
> > buffer "
> >             
> > "WITH desc. update)\n");
> >         
> > dev_info(&dev->pdev->dev, "DMA mode (%s)\n",
> > "PPBDU");
> >
> >
> >     
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/