Re: [PATCH] UCB1400: Pass ucb1400-gpio data through ac97 bus

[Andrew Morton]

On Fri, 27 Aug 2010 07:50:37 +0200 Marek Vasut <marek.vasut@xxxxxxxxx> wrote:

> Dne P__ 27. srpna 2010 01:07:36 Andrew Morton napsal(a):
> > On Mon, 9 Aug 2010 06:43:14 +0200
> > 
> > Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> > > Dne Po 9. srpna 2010 06:16:34 Marek Vasut napsal(a):
> > > > Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
> > 
> > Please don't send unchangelogged patches.
> 
> Unchangelogged? What do you mean ?

Patches which don't have any changelog.  This patch was sent with no
covering explanation.

> > 
> > The title tells us what the patch does but provides no hint as to why
> > it does it.

As I indicated.  The title tells us what the patch does but didn't tell
us *why* it does it.  Apparently it is preparatory work for some other
patch?

> > > > ---
> > > > 
> > > >  drivers/gpio/ucb1400_gpio.c |   19 ++++++-------------
> > > >  drivers/mfd/ucb1400_core.c  |    5 +++++
> > > >  include/linux/ucb1400.h     |   19 ++++++-------------
> > > >  3 files changed, 17 insertions(+), 26 deletions(-)
> > > 
> > > Ah right, guys, if possible, let this go through Eric Miao's tree (as I
> > > have changes that depend on this). Thanks!
> > 
> > He's probably unaware of the patch.  Let's cc him.
> 
> I have this one in my tree and I sent it to Eric as a part of larger patchset.

Recently, I assume - it wasn't in this morning's linux-next.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/