Re: [PATCH 1/5] cgroup: ID notification call back

From: KAMEZAWA Hiroyuki
Date: Tue Aug 24 2010 - 20:42:52 EST


On Tue, 24 Aug 2010 17:34:38 -0700
Paul Menage <menage@xxxxxxxxxx> wrote:

> On Tue, Aug 24, 2010 at 5:20 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> >
> > Hmm, sure. I'll change the ->create() interface. ÂO.K. ?
> >
>
> Hmm. An alternative (possibly cleaner) would be:
>
> 1) add a css_size field in cgroup_subsys that contains the size of the
> per-subsystem structure
> 2) change cgroups to allocate and populate the css *before* calling
> create(), since it now knows the actual size
> 3) simplify all the subsystem create() methods since they no longer
> have to worry about allocation or out-of-memory handling
> 4) also add a top_css field in cgroups that allows cpusets to use the
> statically-allocated top_cpuset since it's initialized prior to memory
> allocation being reliable
>
> This avoids us having to pass in any new parameters to the create()
> method in future since they can be populated in the CSS.
>

Ou...I'm sorry but I would like to use attach_id() for this time.
Forgive me, above seems a big change.
I'd like to write a series of patch to do above, later.
At least, to do a trial.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/