Re: [PATCH 6/8] xfs: fix unsigned underflow

From: Alex Elder
Date: Tue Jul 20 2010 - 15:35:40 EST


On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote:
> On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote:
> > map_len is unsigned. Checking map_len <= 0 is buggy when it should be
> > below zero. So, check exact expression instead of map_len.
> >
> > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>

Looks good to me too. Do you want me to pull this
in via the XFS tree, or do you have other plans?

-Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/