Re: [PATCHv3 1/3] USB: gadget: mass/file storage: set serial number

[MichaÅ Nazarewicz]

> > > Plus, you seem to be overlooking the basic need
> > > (for userspace) to manage these IDs so they're
> > > properly unique.  Two gadgets should never end
> > > up using the same serial number

> --- On Tue, 7/20/10, MichaÅ Nazarewicz <m.nazarewicz@xxxxxxxxxxx> wrote:
> > I'm not overlooking that.  I simply consider that a separate
> > issue. Driver should provide some kind of default.

On Tue, 20 Jul 2010 17:01:37 +0200, David Brownell <david-b@xxxxxxxxxxx> wrote:
> It can't do that and guarantee uniqueness.

I never claimed otherwise.

> Your concept is (still/again) broken.

I don't buy that.  The driver works better with a non-unique
serial number then without any.  As such, a default serial
number should, in my opinion, be provided.

> > (just like File Storage Gadget) and the fact that user space
> > should override it is another matter in my opinion.

> The value must come from userspace in the first
> place, else it can't be correctly managed!!

I would say it *should* come from userspace but if userspace fails to
provide one *something* is better then *nothing*.  I see how gadgets
should print a warning if serial is not provided from user space but
other then that I still think gadget should provide some value.

--
Best regards,                                        _     _
| Humble Liege of Serenely Enlightened Majesty of  o' \,=./ `o
| Computer Science,  MichaÅ "mina86" Nazarewicz       (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/